Skip to content

Fix choose file button position with RTL languages#186

Merged
julien-nc merged 1 commit intomainfrom
fix/noid/rtl-choose-file-button-position
Jan 28, 2025
Merged

Fix choose file button position with RTL languages#186
julien-nc merged 1 commit intomainfrom
fix/noid/rtl-choose-file-button-position

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Jan 27, 2025

LTR

image

RTL Before

image

RTL After

image

For some reason left must be unset when right is defined and the other way around.

cc @DaphneMuller

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added bug Something isn't working 3. to review labels Jan 27, 2025
Copy link
Member

@janepie janepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@julien-nc julien-nc merged commit 4d2a8bf into main Jan 28, 2025
9 checks passed
@julien-nc julien-nc mentioned this pull request Feb 25, 2025
@jancborchardt jancborchardt deleted the fix/noid/rtl-choose-file-button-position branch February 25, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants